Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tabs accessibility.mdx #3661

Merged
merged 30 commits into from
Aug 30, 2023
Merged

Update tabs accessibility.mdx #3661

merged 30 commits into from
Aug 30, 2023

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Jul 26, 2023

Updating accessibility tab content

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 5:26pm

added info on scrollable tabs
Fixing missing opening tag
added new images and tried switching up the narrative a bit. Also experimenting with image presentation
Adopted first image pair and updated ALT text and caption
updated description of scrolling
modified the caption for manual versus automatic
changes to the dev considerations
reversed order of some information for readability
altered style of text indicating a key press
@mbgower mbgower marked this pull request as ready for review August 1, 2023 20:36
@mbgower mbgower requested review from a team as code owners August 1, 2023 20:36
mbgower and others added 6 commits August 23, 2023 12:28
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
mbgower and others added 2 commits August 23, 2023 12:42
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: Mike Gower <mikegower@gmail.com>
@laurenmrice laurenmrice self-requested a review August 24, 2023 17:32
@mbgower mbgower changed the title Update accessibility.mdx Update tabs accessibility.mdx Aug 28, 2023
Replaced the lo-fi tab operation diagram pair with something that includes information in the tab panels as well.
@laurenmrice
Copy link
Member

laurenmrice commented Aug 29, 2023

@alisonjoseph or @andreancardona

  • Hey devs, this keeps failing the ci format, if someone could help Michael fix it.
  • The do images should also be 6 columns, but it is not showing up correctly.

Thank you!

altered column width for 2 and upgraded images for 2, 3 and 4
Copy link
Contributor Author

@mbgower mbgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @laurenmrice

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbgower mbgower merged commit f4db6d7 into main Aug 30, 2023
6 checks passed
@mbgower mbgower deleted the component-tags-accessibility branch August 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants